Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pick cgo arg from env #1095

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Conversation

SVKREP
Copy link
Contributor

@SVKREP SVKREP commented Oct 6, 2023

Retrieve CGO argument value from Environment.

We can now set CGO argument like below:

 CGO_ENABLED=1 make build 

Signed-off-by: Vamsi Krishna <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bbafac) 14.76% compared to head (7a1c823) 14.76%.
Report is 1 commits behind head on main.

❗ Current head 7a1c823 differs from pull request most recent head b6568fd. Consider uploading reports for the commit b6568fd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1095   +/-   ##
=======================================
  Coverage   14.76%   14.76%           
=======================================
  Files          90       90           
  Lines        8379     8379           
=======================================
  Hits         1237     1237           
  Misses       6824     6824           
  Partials      318      318           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal added the lfx-project https://lfx.linuxfoundation.org/tools/mentorship/ label Dec 13, 2023
@kmehant kmehant self-requested a review December 14, 2023 04:45
Copy link
Member

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmehant
Copy link
Member

kmehant commented Dec 14, 2023

@HarikrishnanBalagopal lets merge it! Thanks.

@HarikrishnanBalagopal HarikrishnanBalagopal enabled auto-merge (squash) January 4, 2024 09:00
@HarikrishnanBalagopal HarikrishnanBalagopal merged commit aa79dfa into konveyor:main Jan 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat lfx-project https://lfx.linuxfoundation.org/tools/mentorship/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants