feat: UI support for invokedByDefault transformers #128
Conversation
|
Thanks for making a pull request! 😃 |
Signed-off-by: Mehant Kammakomati <[email protected]>
kmehant
force-pushed
the
make-source-optional
branch
from
8343351 to
c18dd86
Compare
src/app/qa/MultiLine.tsx
Outdated
| @@ -20,7 +20,7 @@ import { QAContext } from './QAContext'; | |||
| import { IQAComponentProps } from './QAWizard'; | |||
| import { TextContent, TextArea } from '@patternfly/react-core'; | |||
|
|
|||
| function Multiline(props: IQAComponentProps): JSX.Element { | |||
| function MultiLine(props: IQAComponentProps): JSX.Element { | |||
There was a problem hiding this comment.
Why is this change necessary?
There was a problem hiding this comment.
@HarikrishnanBalagopal @ashokponkumar
https://github.com/konveyor/move2kube-ui/pull/128/files#diff-9fbd7a7707d6fad02d98c83cc8c72a94821fa17a1983f54f1ef9c3da59bb1d25R113
Its MultiLineInput in https://github.com/konveyor/move2kube/blob/main/types/qaengine/problem.go#L42 and Multiline in UI due to which multi line type questions breaking the QA engine at UI.
Weed need to decide whether following MultiSelect should we change this to MultiLine or change it to MultiLineInput which is there in move2kube code presently.
There was a problem hiding this comment.
In any case, this change is required for the QA engine not to break for multiline questions at UI
There was a problem hiding this comment.
This only changes the function name, it has zero impact in terms of what gets sent over the wire. Can you explain the bug you are seeing?
There was a problem hiding this comment.
Can you please check the completes changes? Function name is changed just for the styling. other changes fixes the issue. Thanks
There was a problem hiding this comment.
I see the issue https://github.com/konveyor/move2kube/blob/main/types/qaengine/problem.go#L42
currently has MultiLineInput and the QA Wizard https://github.com/konveyor/move2kube-ui/blob/main/src/app/qa/QAWizard.tsx#L113 has Multiline
The only change required is to change https://github.com/konveyor/move2kube-ui/blob/main/src/app/qa/QAWizard.tsx#L113 to MultiLineInput to match the CLI. It also makes it similar to Input we already have. https://github.com/konveyor/move2kube-ui/blob/main/src/app/qa/QAWizard.tsx#L111
There was a problem hiding this comment.
But by the semantic meaning Input can be anything.
There was a problem hiding this comment.
Why notMultiSelectInput 🤔
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
|
@HarikrishnanBalagopal Made the changes, please review! |
|
fixes #129 |
Signed-off-by: Mehant Kammakomati [email protected]