Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improving how to use docker or podman to run locally #106

Merged
merged 3 commits into from
Oct 14, 2021
Merged

feat: Improving how to use docker or podman to run locally #106

merged 3 commits into from
Oct 14, 2021

Conversation

rmarting
Copy link
Contributor

This PR extends the initial works done in the previous PR #98

This PR includes:

  • Mounting data folder for docker and podman
  • Allow to use podman-compose to start a local container
  • Documentation improvements

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Oct 14, 2021
ashokponkumar
ashokponkumar approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@ashokponkumar ashokponkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmarting for your constant improvements!

@ashokponkumar ashokponkumar merged commit dd88ce0 into konveyor:main Oct 14, 2021
@rmarting rmarting mentioned this pull request Oct 14, 2021
Merged
@rmarting
Copy link
Contributor Author

Wow! It seems that it was the most quickly PR of my life! :) Thanks @ashokponkumar!

@rmarting rmarting deleted the feat-using-podman branch October 14, 2021 16:40
@ashokponkumar
Copy link
Member

Wow! It seems that it was the most quickly PR of my life! :) Thanks @ashokponkumar!

Thanks for your constant support to the project :) Will try to keep it as painless as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokponkumar ashokponkumar ashokponkumar approved these changes

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmarting @ashokponkumar