Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the reverse DNS lookup which fails in multiple cases and takes unnecessarily long #115

Conversation

HarikrishnanBalagopal
Copy link
Contributor

Signed-off-by: Harikrishnan Balagopal [email protected]

…takes unnecessarily long

Signed-off-by: Harikrishnan Balagopal <[email protected]>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Jul 31, 2022
…es and takes unnecessarily long

Signed-off-by: Harikrishnan Balagopal <[email protected]>
@ashokponkumar
Copy link
Member

Manually configuring the hostname would not be feasible in situations like when using pods, esp stateful pods in say a Kubernetes deployment.

@HarikrishnanBalagopal
Copy link
Contributor Author

Manually configuring the hostname would not be feasible in situations like when using pods, esp stateful pods in say a Kubernetes deployment.

Actually we don't need to configure it manually.
That's what the K8s downward API is for https://kubernetes.io/docs/concepts/workloads/pods/downward-api/
I have made the change to the Helm chart as well. Will push it to UI.

@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 1d6d641 into konveyor:main Jul 31, 2022
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the fix/removereversednslookup branch July 31, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants