✨ Load state from files and create apply/revert/copy commands #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rszwajko
requested review from
djzager,
ibolton336,
hhpatel14,
sjd78 and
savitharaghunathan
and removed request for
djzager and
ibolton336
rszwajko
changed the title
Key points:
1. make the data folder(.vscode/konveyor) the main permanent storage.
This replaces the current usages of vscode.workspaceState.
2. store analysis results and received solutions directly in the
extension state. Both values are frequently read from the command
layer. Retrieval from the DB adds unnecessary delay.
3. load initial data asynchronously on extension start
4. implement commands: applyAll,applyFile, revertAll, revertFile,
copyPath, copyDiff
5. create loadResultsFromDataFolder command ("Reload results" in the
command palette)for initial data load and development.
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
force-pushed
the
acceptChange
branch
from
592e469 to
f06e9eb
Compare
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key points:
This replaces the current usages of vscode.workspaceState.
extension state. Both values are frequently read from the command
layer. Retrieval from the DB adds unnecessary delay.
copyPath, copyDiff
command palette)for initial data load and development.
Resolves: #48
Resolves: #72