Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Start kai/rpc-server #81

Merged
merged 3 commits into from
Nov 8, 2024
Merged

✨ Start kai/rpc-server #81

merged 3 commits into from
Nov 8, 2024

Conversation

hhpatel14
Copy link
Contributor

@hhpatel14 hhpatel14 commented Oct 23, 2024 •
edited by djzager
Loading

  • Add kai-rpc server Path property which user can override

Fixes #62 #64

@hhpatel14 hhpatel14 requested a review from djzager October 23, 2024 18:26
djzager
djzager requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. You'll find a lot of nitpicky type comments but this is a great start.

vscode/src/client/analyzerClient.ts Outdated Show resolved Hide resolved
vscode/src/client/analyzerClient.ts Outdated Show resolved Hide resolved
vscode/src/client/analyzerClient.ts Outdated Show resolved Hide resolved
vscode/src/client/analyzerClient.ts Outdated Show resolved Hide resolved
vscode/package.json Outdated Show resolved Hide resolved
vscode/package.json Outdated Show resolved Hide resolved
@hhpatel14 hhpatel14 force-pushed the issuse#62 branch 6 times, most recently from 24fa28a to de731e8 Compare October 25, 2024 18:02
@hhpatel14 hhpatel14 changed the title [WIP] Start kai/rpc-server ✨ Start kai/rpc-server Oct 25, 2024
@hhpatel14 hhpatel14 requested a review from djzager October 25, 2024 18:40
@djzager
Copy link
Member

djzager commented Oct 26, 2024

Note:
Work was done to do kai/rpc-server builds in kai but I don't think we have published builds we can grab yet.

@hhpatel14 hhpatel14 force-pushed the issuse#62 branch 4 times, most recently from 3173f39 to 07c9539 Compare October 27, 2024 19:45
djzager
djzager requested changes Nov 7, 2024
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few name changes. This doesn't appear to do anything with the kai rpc server, but that's actually perfect to get this stuff in without breaking anything.

vscode/package.json Outdated Show resolved Hide resolved
vscode/src/client/analyzerClient.ts Outdated Show resolved Hide resolved
vscode/src/commands.ts Outdated Show resolved Hide resolved
@hhpatel14 hhpatel14 requested a review from djzager November 7, 2024 19:45
djzager
djzager previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work!

vscode/media/walkthroughs/override-analyzer.md Outdated Show resolved Hide resolved
vscode/package.json Outdated Show resolved Hide resolved
@hhpatel14
Update few name
db9735f 
Signed-off-by: hhpatel14 <[email protected]>
@hhpatel14 hhpatel14 merged commit d5bac40 into konveyor:main Nov 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vscode] Start kai/rpc-server
2 participants
@hhpatel14 @djzager