✨ Add configuration for getSolution params #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjd78
requested changes
Dec 11, 2024
There was a problem hiding this comment.
The code flow looks ok to me.
The descriptions will need rewording, or the entire way we handle configuring Kai settings will (hopefully eventually) be redone so it's not just a series of quick picks and input values.
Only blocking comment is the description for getSolutionMaxPriority. If this is the correct description, comment as such and I'll be an approve.
ibolton336
force-pushed
the
config-get-solution
branch
2 times, most recently
from
e00a115 to
94abf81
Compare
sjd78
reviewed
Dec 11, 2024
Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
ibolton336
force-pushed
the
config-get-solution
branch
from
e6abc22 to
cfb209e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-12-10.at.4.25.14.PM.mov