Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add counts and styling for incident / issues #145

Merged
merged 1 commit into from
Dec 10, 2024
Merged

✨ Add counts and styling for incident / issues #145

merged 1 commit into from
Dec 10, 2024

Conversation

ibolton336
Copy link
Member

Screenshot 2024-12-09 at 4 43 25 PM

@ibolton336 ibolton336 requested a review from a team as a code owner December 9, 2024 21:45
@ibolton336 ibolton336 force-pushed the issue-count branch 2 times, most recently from d3965ab to d0468e9 Compare December 9, 2024 21:46
rszwajko
rszwajko previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - see comments for minor issues

webview-ui/src/components/ViolationsCount/ViolationsCount.tsx Outdated Show resolved Hide resolved
webview-ui/src/components/ViolationsCount/ViolationsCount.tsx Outdated Show resolved Hide resolved
@ibolton336
✨ Add counts and styling
1086ccd 
Signed-off-by: Ian Bolton <[email protected]>
sjd78
sjd78 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd like to remove const [analysisMessage, setAnalysisMessage] = useState(""); in AnalysisPage.tsx since it isn't set anywhere and it just throwing lint errors, that would be sweet.

Else, LGTM

@ibolton336 ibolton336 merged commit b781ac7 into konveyor:main Dec 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rszwajko rszwajko rszwajko approved these changes

@sjd78 sjd78 sjd78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibolton336 @sjd78 @rszwajko