-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add server status component #127
Conversation
Signed-off-by: Ian Bolton <[email protected]>
cc34c3f
to
be8724f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
Signed-off-by: Ian Bolton <[email protected]>
3f11638
to
368de80
Compare
Signed-off-by: Ian Bolton <[email protected]>
368de80
to
7787daa
Compare
@ibolton336 |
I like having explicit status for the server available. Back on the wireframes, I thought of it more as a status bar item with wireframe 10 (described but not drawn -- it is the blue bar in the status area in the wireframe image below). Wireframe 14 has the progression from not configured forward... In terms of UX, the server should manage itself like any other language server would. If things are configured when the extension initializes, just start the server up right away. The user changes the configs? Restart the server. The extensions gets reloaded? Stop and start the server again. For our purposes, manually starting and stopping the server can make a lot of sense as the start and initalize code can be changing. Keeping those actions around and having a full set of server actions start, restart, and stop that can be hit from the command pallet is very vscode UX consistent. Showing server status in the status bar is also far more vscode UX consistent. |
I agree with this being the longterm goal for the extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. I think we can iterate on this server status as we getting working on more systems more reliably in the coming weeks.
Screen.Recording.2024-12-03.at.8.08.05.PM.mov