Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/preview edit links #225

Closed
wants to merge 5 commits into from

Conversation

nkooman
Copy link

@nkooman nkooman commented Sep 5, 2023

Motivation

Which issue does this fix? Fixes #81

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
This issue was created before Web Spotlight and the Smart Link SDK existed. The suggested solution called out manually creating and rendering edit links. Since the Smark Link SDK exists it became a lot easier to implement this functionality.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

  1. Create a sample Kontent environment. You will need to be able to configure spaces and preview URLs.
  2. Configure the environment for preview mode in localhost.
  3. Add the preview API key to your environment variables.
  4. Run the site and view any page.

@nkooman nkooman requested review from IvanKiral and a team as code owners September 5, 2023 03:46
@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for kontent-sample-app-react ready!

Name Link
🔨 Latest commit d24da83
🔍 Latest deploy log https://app.netlify.com/sites/kontent-sample-app-react/deploys/64f6a49c3840750008c8375f
😎 Deploy Preview https://deploy-preview-225--kontent-sample-app-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IvanKiral
Copy link
Contributor

Hey Nick! Thank you for the PR. 💯 I will put this review into my backlog :)

@IvanKiral
Copy link
Contributor

Hey Nick! We are grateful for your PR.

Currently, we are working on a new sample project, which will cover the functionality of using Smartlink SDK. Therefore, your changes might be replaced in the near future (let's say something like in half a year).

If you would like to still to merge this PR, let us know. However, there are some things that need to be done, for example:

  • Let's find some better logic for invoking the Smartlink rather than always removing and adding the preview API key in envId.
  • During preview in listing pages, you cannot get into article detail, which would be nice to handle
  • There are some technical nitpicks, like using any in Richtext,...

@nkooman-bzs
Copy link

If a new sample project is in the works, I think we can close this PR.
Can't wait to see the new and improved version!

@nkooman nkooman closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Preview Edit Links
3 participants