Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CLI message should depend on Homebrew not GitHub release #1746

Closed
1 task done
fharper opened this issue Aug 1, 2023 · 0 comments
Closed
1 task done

Upgrade CLI message should depend on Homebrew not GitHub release #1746

fharper opened this issue Aug 1, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@fharper
Copy link
Contributor

fharper commented Aug 1, 2023

Which version of kubefirst are you using?

ALL

Which cloud provider?

None specific

Which installation type?

None specific

Which distributed Git provider?

None specific

What is the issue?

Since it take a couple of hours between a new release, and Homebrew core PR to be merged, the upgrade message should check if a newer version is available on Homebrew, and not from the kubefirst repository release.

It is needed since this messager focus on macOS user.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fharper fharper added the bug Something isn't working label Aug 1, 2023
fharper added a commit that referenced this issue Aug 16, 2023
@fharper
fix: check new version from homebrew-core instead of k1 repo (fix #1746)
55ab680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fharper