-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updating docs for mkcert #832
Conversation
Since it's not in the commit message, for history, there is also a lot of correction of branding naming in this commit. @konstructcarrie there is also the addition of Azure in 2.7, is it wanted also? Just want to be sure as this PR was just for |
I removed the Azure directory from the 2.7 version. I wasn't thinking about the fact that it was on hold until 2.8 |
@konstructcarrie you also need to remove Azure references in the sidebar for 2.7 |
Yeah I did that but there are also imports/references that I'm not sure how to remove that are killing the build. @mrsimonemms |
I can give a look tomorrow to fix the build if Simon doesn't have time, let me know. Even if we release 2.8 tomorrow, Azure is now available in 2.7, so the docs should be in 2.7 also @mrsimonemms :) |
I've created a PR to add the fix into this PR - please take a look and see if you're happy adding into this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
It might be worth making a common component that contains all the "we use mkcert
" paragraph so that we only have to actually write it once. We can do this afterwards though
Description
Adding mkcert details to install instructions for all clouds and updating current 2.7 version with these changes
Added these details for Azure for vNext
Fixes instances of kubefirst for capitalization (other branding updates)
Related Issue(s)
None found
How to test
Validate that content appears where expected before this step https://kubefirst.konstruct.io/docs/aws/quick-start/install/cli#create-your-new-kubefirst-cluster for each cloud