Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): Add NodeJS to runtime images #49

Merged
merged 4 commits into from
Jan 24, 2023
Merged

feat(): Add NodeJS to runtime images #49

merged 4 commits into from
Jan 24, 2023

Conversation

aacecandev
Copy link
Contributor

Add NodeJS to runtime images

Description

This PR installs NodeJS with Apt Using a NodeSource PPA

Motivation and Context

There's a need for installing NodeJS in those images that are being used in Github self-hosted runners because using the actions by itself is not possible since they use the PATH /__t as temporary path when installing actions/setup-node.

Our runtimes are configured to run as user with UID 1000 by default, but Github runners need to create that folder using the user 1001.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other changes (ci configuration, documentation or any other kind of changes)

Checklist:

  • I have executed the pre-commit hooks locally.

@aacecandev aacecandev added the dependencies Pull requests that update a dependency file label Jan 19, 2023
@aacecandev aacecandev self-assigned this Jan 19, 2023
blopezpi
blopezpi previously approved these changes Jan 19, 2023
@aacecandev
Copy link
Contributor Author

aacecandev commented Jan 24, 2023

This PR must be merged ASAP to make CML with our fix available to go ahead with the new methodology implementation.

iterative/cml#1326

@aacecandev aacecandev merged commit b5caaf2 into main Jan 24, 2023
@aacecandev aacecandev deleted the feat/add-nodejs branch January 24, 2023 13:05
@IGZEnriqueRomera
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@IGZEnriqueRomera
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@IGZEnriqueRomera
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@IGZEnriqueRomera
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@IGZEnriqueRomera
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@IGZEnriqueRomera
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@IGZEnriqueRomera
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@IGZEnriqueRomera
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@IGZEnriqueRomera
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@IGZEnriqueRomera
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@IGZEnriqueRomera
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants