Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELFReader methods do not always close streams #91

Closed
ljusten opened this issue Jan 9, 2023 · 3 comments
Closed

ELFReader methods do not always close streams #91

ljusten opened this issue Jan 9, 2023 · 3 comments

Comments

@ljusten
Copy link

ljusten commented Jan 9, 2023

If shouldOwnStream is true, the methods should close the stream if loading fails. Otherwise, for instance ELFReader.TryLoad(filename, out IELF elf) won't close the stream if the file is not an ELF file.
copybara-service bot pushed a commit to googlestadia/vsi-lldb that referenced this issue Jan 10, 2023
@ljusten @copybara-github
[YetiCommon] Scramble test binaries
bb8038c 
Applies b -> 255-b for every byte of the test binaries of
ModuleParserTests in order to prevent binary detection.

Also works around a bug in ElfSharp where files are not always closed,
see konrad-kruczynski/elfsharp#91. This
lead to errors deleting temp files.

GitOrigin-RevId: 107cfffd226c69dde2ad2d3bdd378be2aba3ef55
@konrad-kruczynski
Copy link
Owner

Confirmed, will fix that.

konrad-kruczynski added a commit that referenced this issue Jan 11, 2023
@konrad-kruczynski
ELF: close underlying stream on load fail (if owned).
58f5860 
Fixes issue #91.
@konrad-kruczynski
Copy link
Owner

ELFSharp 2.16.1 published, closing ticket.

@ljusten
Copy link
Author

ljusten commented Jan 13, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@konrad-kruczynski @ljusten