Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated swagger-core to version 1.6.1 to support 'parseValue' in 'extensions' #877

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ankrim
Copy link

@ankrim ankrim commented Jan 7, 2022

In version 1.6.1 swagger-core (and swagger-annotations) added support for the parseValue property as part of the @ExtensionProperty annotation.
If parseValue is true the provided value is treated as json and it's parsed into the generated OpenAPI file as a nested object or an array (instead of as a string).

In this PR I upgraded the swagger-core library from 1.5.21 to 1.6.1 and updated the relevant tests (same as in https://github.com/kongchen/swagger-maven-plugin/pull/582/files).

I also upgraded other libraries to try to make mvn install work (but it doesn't) and run the tests in Intellij (that works), so these changes might not be needed if mvn install works in the CI.
I was able to make mvn install -DskipTests work with the additional libraries upgrades only if I manually disable the check-java16-sun execution (in animal-sniffer-maven-plugin).
Please let me know if you want to keep these additional upgrades or remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant