This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
Decomission of SnapshotEnvironmentBinding controller #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Shaposhnyk <[email protected]>
Signed-off-by: Max Shaposhnyk <[email protected]>
skabashnyuk
approved these changes
Mar 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshaposhnik, skabashnyuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mshaposhnik
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since SEB-s are subject to upcoming removal, there is no need to have a target setting controller anymore.
Targets for push and pull secrets will be created automatically on apllication component processing, (see konflux-ci/image-controller#97)
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/SVPI-728
How to test this PR?