feat(STONEINTG-843): add consoleURL plr to github checkrun

[kasemAlem]

We added new field to github endpoint CheckRun and CommitStatus on the creation :

• CheckRun -> DetailsURL
• CommitStatus -> TargetURL

For more details see STONEINTEG-843

Maintainers will complete the following section

• Commit messages are descriptive enough (hints)
• Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
• Controllers diagrams are updated when PR changes controllers code (if applicable)

[kasemAlem]

/retest

[kasemAlem]

/retest required

[openshift-ci]

@kasemAlem: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

• /test images
• /test integration-service-e2e

Use /test all to run all jobs.

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kasemAlem]

/test all

[dirgim]

I think that the commit (and also PR) title shouldn't be marked as fix, but as feat since this is an implementation of a regular story and not a bugfix. It should also contain the reference to the STONEINTG-843 story instead of stoneintg so we can easily find the referenced jira item in the future.

Also, the title is currently too long and is failing the gitlint check.

[dirgim]

/retest

[kasemAlem]

/retest required

[openshift-ci]

@kasemAlem: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

• /test images
• /test integration-service-e2e

Use /test all to run all jobs.

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kasemAlem]

/test all

[hongweiliu17]

/test integration-service-e2e

[codecov]

Codecov Report

Attention: Patch coverage is 81.08108% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 72.56%. Comparing base (0128956) to head (2dabb6b).
Report is 11 commits behind head on main.

Files	Patch %	Lines
status/reporter_github.go	69.23%	2 Missing and 2 partials ⚠️
git/github/github.go	78.57%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   72.74%   72.56%   -0.18%     
==========================================
  Files          46       46              
  Lines        4590     4615      +25     
==========================================
+ Hits         3339     3349      +10     
- Misses        900      912      +12     
- Partials      351      354       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hongweiliu17]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[dirgim]

/retest

[dirgim]

LGTM

[14rcole]

It looks like you added this in so that you could call FormatPipelineURL in reporter_github.go. Why not just add a URL parameter to the report and call FormatPipelineURL here?

I ask because this is the approach I'm taking in STONEINTG-842. It works, but whatever we do should be the same so I can switch to your approach if there's some advantage to it.