feat(STONEINTG-781): remove finalizer sooner for integration plr #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Everett
changed the title
dirgim
requested review from
MartinBasti,
dheerajodha,
hongweiliu17,
14rcole,
dirgim,
jsztuka and
kasemAlem
dirgim
reviewed
Mar 19, 2024
dirgim
reviewed
Mar 19, 2024
|
Note that the diagram for the statusreport controller will also need to be updated, at least around this part. |
MartinBasti
reviewed
Mar 19, 2024
dirgim
reviewed
Mar 21, 2024
MartinBasti
reviewed
Mar 21, 2024
Josh-Everett
force-pushed
the
781
branch
2 times, most recently
from
fe930f1 to
ac36a4e
Compare
|
/retest |
dirgim
reviewed
Apr 9, 2024
dirgim
approved these changes
Apr 9, 2024
MartinBasti
reviewed
Apr 10, 2024
Josh-Everett
force-pushed
the
781
branch
3 times, most recently
from
70c9800 to
50536d9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 72.74% 72.36% -0.39%
==========================================
Files 46 46
Lines 4590 4657 +67
==========================================
+ Hits 3339 3370 +31
- Misses 900 931 +31
- Partials 351 356 +5 ☔ View full report in Codecov by Sentry. |
MartinBasti
approved these changes
Apr 11, 2024
Previously integration-service was prematurely removing finalizers from "optional" Integration PLRs since they aren't considered while marking the snapshot as finished. The logic for these PLRS have been changed to remove their finalizers after they are finished, their status has been recorded by the snapshot, and their status has reported to GH. Signed-off-by: Josh Everett <[email protected]>
|
dirgim
approved these changes
Apr 17, 2024
|
Update to d8cc291 was just a rebase so I think this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainers will complete the following section