allow custom user renovate configs, in config maps, #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcerven
changed the title
rcerven
force-pushed
the
renovatecustomconfig
branch
2 times, most recently
from
1e6cad7 to
160da4d
Compare
rcerven
changed the title
tnevrlka
reviewed
Nov 15, 2024
rcerven
force-pushed
the
renovatecustomconfig
branch
from
160da4d to
11f36c0
Compare
|
related docs PR: konflux-ci/docs#171 |
rcerven
force-pushed
the
renovatecustomconfig
branch
from
11f36c0 to
522bc15
Compare
mmorhun
approved these changes
Nov 15, 2024
controllers/suite_util_test.go
Outdated
| @@ -635,3 +646,19 @@ func deletePipelineServiceAccount(namespace string) { | |||
| pipelineServiceAccountkey := types.NamespacedName{Name: buildPipelineServiceAccountName, Namespace: namespace} | |||
| deleteServiceAccount((pipelineServiceAccountkey)) | |||
| } | |||
|
|
|||
| func deleteConfigMap(configMapKey types.NamespacedName) { | |||
There was a problem hiding this comment.
Nitpick: better move to ConfigMap functions
| globalConfigType := "" | ||
|
|
||
| allUserConfigMaps := &corev1.ConfigMapList{} | ||
| if err := u.Client.List(ctx, allUserConfigMaps, client.InNamespace(namespace)); err != nil { |
There was a problem hiding this comment.
Should we have a common label on all nudge-renovate ConfigMaps?
There was a problem hiding this comment.
I wouldn't complicate it more for users tbh
sure finding could be filtered, but on other hand with missing label users would complain that it doesn't work
so better less things for them to set
there can be one global one for all components, and also custom config for specific components we are also now creating renovate config in json format STONEBLD-2916 KONFLUX-4372 KFLUXBUGS-1777 Signed-off-by: Robert Cerven <[email protected]>
rcerven
force-pushed
the
renovatecustomconfig
branch
from
522bc15 to
809e7fc
Compare
tnevrlka
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there can be one global one for all components, and also custom config for specific components
we are also now creating renovate config in json format
STONEBLD-2916
Checklist:
make testpasses