RHTAPSRE-469: Webhook configuration based on repo url #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to configure the webhook target url based on the repository url of the component by providing a config file. Configuring the webhook target url using environment variable has precedence. In case that no config file or environment variable for configuring the webhook target are provided, the PAC route will be used (same as before this change). Signed-off-by: gbenhaim <[email protected]>
|
|
/test build-service-e2e |
|
@gbenhaim could you also explain in the PR description for which use cases this functionality is needed? |
|
@mmorhun done |
mmorhun
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
You'll have to reference changes from redhat-appstudio/application-service#450 before merging
Those two PRs are not dependent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to configure the webhook target url based on the repository url of the component by providing a config file.
Configuring the webhook target url using environment variable has precedence.
In case that no config file or environment variable for configuring the webhook target are provided, the PAC route will be used (same as before this change).
An example use case would be for a cluster that sits behind a firewall, and need to receive webhooks from SCMs outside of the firewall (through a relay service) and also from SCMs within the firewall, in this case the webhooks can be emitted directly to the PAC endpoint on the cluster, instead of the relay service.