fix(prefetch): fail step when error happen #1756
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBasti
requested review from
brunoapimentel,
eskultety,
taylormadore and
a team
as code owners
MartinBasti
force-pushed
the
prefetch-fail-on-error
branch
from
a97c1e4 to
0f4f1b3
Compare
chmeliik
approved these changes
Dec 16, 2024
Comment on lines
411
to
+415
| image: quay.io/redhat-appstudio/cachi2:0.15.0@sha256:b141cb5cf4d98e6c5f668f1fe172e1d68f2a44ac1027403fbcff94ce1e68185d | ||
| script: | | ||
| #!/bin/bash | ||
|
|
||
| set -euo pipefail |
There was a problem hiding this comment.
Oof, I just saw the unregister-rhsm step at the end. This means the prefetch task will only unregister itself if it succeeds, otherwise it will leave a registration hanging around in the system.
But exiting on failure properly probably doesn't make that problem much worse than it already was
There was a problem hiding this comment.
questionable is, how much of hanging are we talking about in ephemeral tasks
There was a problem hiding this comment.
I can rework it to hard way using an internal state
There was a problem hiding this comment.
by hard way I mean to trap errror, record it and skip all tasks except unregister
|
/retest |
Task were failing silently causing harder to debug errors or misleding users that different step failed. Ensure that steps aren't failing silently and we don't run unnecessary steps after failure. Signed-off-by: Martin Basti <[email protected]>
MartinBasti
force-pushed
the
prefetch-fail-on-error
branch
from
0f4f1b3 to
b86dc89
Compare
|
e2e Fails at this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task were failing silently causing harder to debug errors or misleding users that different step failed. Ensure that steps aren't failing silently and we don't run unnecessary steps after failure.
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.