clair: only run clair-action once and convert output #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
|
How does one go about being able to access the |
dirgim
requested review from
zregvart,
jsztuka,
hongweiliu17,
dirgim,
sonam1412,
Josh-Everett,
dheerajodha,
jencull,
kasemAlem and
chipspeak
Unfortunately the logs are not stored anywhere publicly, you'd need cluster access to see them. I'll rebase this and have it run again and attach the logs here. |
By adding the convert command to the clair-action cli the clair-scan task can take advantage and only call the expensive reporting command once. Signed-off-by: crozzy <[email protected]>
zregvart
force-pushed
the
wip-convert-clair-output
branch
from
e2d37d9 to
8fdbf22
Compare
|
/ok-to-test |
zregvart
approved these changes
Nov 28, 2024
|
The logs from the e2e test don't tell much The span up PipelineRun had this TaskRun emit an error: |
|
Nice, I guess that is to be expected until the |
|
cc @p-rog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding the convert command to the clair-action cli the clair-scan task can take advantage and only call the expensive reporting command once.
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.