Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plantingjs from npm #68

Merged
merged 7 commits into from
Jan 25, 2016
Merged

Plantingjs from npm #68

merged 7 commits into from
Jan 25, 2016

Conversation

magul
Copy link
Contributor

@magul magul commented Jan 23, 2016

Plantingjs is installed using npm install from repository on github.

All js is bundled into one file, css's and assets are build using dedicated gulp tasks.

We have some problems (404's), but they can be resolved later (AFAIK plantingjs by itself also have problems with some assets, that are unavailable).

@codecov-io
Copy link

Current coverage is 43.33%

Merging #68 into master will not affect coverage as of 77e8e69

@@            master     #68   diff @@
======================================
  Files            6       6       
  Stmts           60      60       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             26      26       
  Partial          0       0       
  Missed          34      34       

Review entire Coverage Diff as of 77e8e69

Powered by Codecov. Updated on successful CI builds.

entries: [file.path],
debug: false,
standalone: 'Planting',
paths: ['./node_modules/', './wysadzulice/assets/'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we always use relative paths?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably right. Because all js modules available in wysadzulice/assets will be imported into main using relative paths, it looks, that we can freely remove this option from browserify.

I will do it at today's meeting.

cmwd added a commit that referenced this pull request Jan 25, 2016
@cmwd cmwd merged commit 3d4e7ce into komitywa:master Jan 25, 2016
@magul magul deleted the plantingjs_from_npm branch February 4, 2016 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants