-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plantingjs from npm #68
Conversation
…s node dependency
Current coverage is
|
entries: [file.path], | ||
debug: false, | ||
standalone: 'Planting', | ||
paths: ['./node_modules/', './wysadzulice/assets/'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we always use relative paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably right. Because all js modules available in wysadzulice/assets
will be imported into main using relative paths, it looks, that we can freely remove this option from browserify.
I will do it at today's meeting.
Plantingjs is installed using
npm install
from repository on github.All js is bundled into one file, css's and assets are build using dedicated gulp tasks.
We have some problems (404's), but they can be resolved later (AFAIK plantingjs by itself also have problems with some assets, that are unavailable).