Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentions of users with . in their usernames aren't rendered correctly #509

Closed
1 task
FitikWasTaken opened this issue Oct 3, 2024 · 2 comments
Closed
1 task

Comments

@FitikWasTaken
Copy link

FitikWasTaken commented Oct 3, 2024

💡 Summary

Any mentions of users with . in their usernames are getting cut after the dot. According to the webfinger specs these 4 symbols are allowed: _ - . ~ ( https://www.w3.org/community/reports/socialcg/CG-FINAL-apwf-20240608/#names )

CherryPick supports the first two, and I have never seen a Fediverse software that supports creating an account with a tilde

However, there are examples of accounts with a dot using different software:

Bridgy Fed: @[email protected]
Threads: @[email protected]
PeerTube: @[email protected]

🥰 Expected Behavior

It should be rendered as a normal mention.

It was fixed in Sharkey, there's a related Sharkey commit: https://activitypub.software/TransFem-org/sfm-js/-/commit/3b5bfe6f6a1701e9abfcd4e7f97a4ff348d6ffbe

🤬 Actual Behavior

It's getting cut and username that should look like @[email protected] is rendered as @cool@[email protected] and it's definitely incorrect

📝 Steps to Reproduce

No response

💻 Frontend Environment

* Model and OS of the device(s): Unrelated
* Browser: Firefox
* Server URL: kitty.social
* CherryPick: 4.12.0-beta.9

🛰 Backend Environment (for server admin)

No response

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@FitikWasTaken
Copy link
Author

I forgot to link it but there's the upstream issue - misskey-dev/mfm.js#143

@noridev noridev mentioned this issue Oct 5, 2024
@noridev
Copy link
Collaborator

noridev commented Oct 5, 2024

Solve to this issue has been completed in kokonect-link/cfm.js. Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants