Fix Visual Studio 2019 compilation errors #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. VS 2019 doesn't compile if you give size_t as a run-time extent to basic_mdspan's constructor. 2. There was another issue in tests/iterator.cpp; it was a lower priority to fix, so I just commented out that code for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS 2019 doesn't compile if you give
size_tas a run-time extent tobasic_mdspan's constructor. I changed all thosesize_tin stdBLAS' tests toptrdiff_t.There was another issue in tests/iterator.cpp; it was a lower priority to fix, so I just commented out that code for now.
Note that we still need to fix BLAS detection (or make it optional) on Windows. This PR does not do that.