Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using system-installed GTest #61

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Jul 2, 2021

Adds CMake option for using a local GoogleTest installation when downloading at build time is not desired/allowed.

My personal motivation for this feature is to support running the unit tests while packaging for Nix, which doesn't allow networking at build time. I think a fair number of other package managers also prohibit networking at build time, although I don't know how common it is to try to run upstream tests.

Adds CMake option for using a local GoogleTest installation
when downloading at build time is not desired/allowed.
@leha-bot
Copy link

Hey, guys, any updates? 😊

@mhoemmen
Copy link
Contributor

We certainly do maintain mdspan. Perhaps we missed this PR. Let me take a look.

Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

As a future improvement, we might want to consider always doing find_package(GTest CONFIG), and only attempting the download if that fails.

@mhoemmen mhoemmen merged commit 3309ce9 into kokkos:stable Jul 18, 2022
@r-burns r-burns deleted the system-gtest branch July 18, 2022 03:47
mhoemmen pushed a commit to mhoemmen/mdspan that referenced this pull request Jul 26, 2023
Rename vector_idx_abs_max to close kokkos#72 and kokkos#61.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants