team-level std algos: part 10 #6256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cezary Skrzyński Co-authored-by: Jakub Strzebonski
Co-authored-by: Cezary Skrzyński Co-authored-by: Jakub Strzebonski
This comment was marked as outdated.
This comment was marked as outdated.
Closed
|
retest this please |
This comment was marked as outdated.
This comment was marked as outdated.
Comment on lines
+154
to
+155
| // FIXME: there is no parallel_scan overload that accepts TeamThreadRange and | ||
| // return_value, so temporarily serial implementation is used |
There was a problem hiding this comment.
This is changing with recent pull requests, though. Let's make sure that we can get this adapted in the near future; ideally even for the release.
There was a problem hiding this comment.
yes, i am going to fix all of this after all the team PRs are merged in a follow up.
crtrott
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Cezary Skrzyński
Co-authored-by: Jakub Strzebonski
Content
Team-level implementation and tests for:
Kokkos_IsSortedUntil.hppKokkos_IsSorted.hppKokkos_IsPartitioned.hppKokkos_PartitionCopy.hppKokkos_PartitionPoint.hppTechnical comments
the change
class->typenameand the enable if defaulted in the template parameters comes from this requestthe code duplication is intentional and agreed upon after the long discussion in here
tests are run for both contiguous views and strided views
Other comments
all team-level PRs are tracked in: Team-level std algorithms PRs: issue tracker #6352
this comes from breaking apart team impl of std algorithms #5150
Possible conflicts
Implementation-wise, this has not conflict with other team-level PRs so it could be merged independently.
However, a trivial conflict in the CMakeLists inside the unit test occurs if another of the team-level PRs is merged before this because each team-level PR adds test using a specific "label". Resolving this is trivial.
Associated wiki PRs
Kokkos_IsSortedUntil.hpp: see wiki PRKokkos_IsSorted.hpp,Kokkos_IsPartitioned.hpp,Kokkos_PartitionCopy.hpp: see wiki PRKokkos_PartitionPoint.hpp: see wiki PRIMPORTANT: wiki PRs are not complete yet but 99% there
The issue tracking all wiki PRs is here