-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/unit_test: separate cuda timing-based tests into separate exe #3407
Conversation
@crtrott @dalg24 since this change is pretty minimal, should it be cherry-picked to release-candidate-3.2.1 to get into Trilinos towards addressing trilinos/Trilinos#6799 ? |
Yeah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trilinos/Trilinos#6799 (comment) and
trilinos/Trilinos#6799 (comment) suggest to rename
UnitTest_Cuda3 -> UnitTest_CudaTimingBased
Why did you decide to create a new executable?
To be clear I don't necessarily have a problem with your solution but you must comment that the changes you propose depart from the resolution that was suggested and why you suggested to do so. |
@dalg24 the timing-based tests themselves were already part of the |
To address issue #3405