Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary cufftCreate and hipfftCreate to avoid creating plans twice #212

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

Fixes #211

In addition, adding check functions after binding streams

@yasahi-hpc yasahi-hpc self-assigned this Dec 5, 2024
@yasahi-hpc yasahi-hpc added the bug Something isn't working label Dec 5, 2024
@yasahi-hpc yasahi-hpc requested a review from tpadioleau December 5, 2024 13:00
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes lgtm

@yasahi-hpc
Copy link
Collaborator Author

Thanks! I will merge this and update #208 on top of it

@yasahi-hpc yasahi-hpc merged commit a323455 into kokkos:main Dec 5, 2024
20 checks passed
@yasahi-hpc yasahi-hpc deleted the fix-redundant-plan-creation branch December 5, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cufftHandle is created twice
2 participants