-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some typos. #206
Fix some typos. #206
Conversation
There is also an other typo in unit_test/Test_Transform.cpp "neeed" that I did not fix because I don't know if it should be "need" or "needed". If you tell me I can rework my PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, did you use any tool to get them ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, thank
Regrading "neeed", they are supposed to be "needed". Could you please also fix them |
While reviewing a pull request, I noticed a first typo and then I decided to check if there were other typos. For this I used the spelling checker inside Vim. |
I have done the update. |
Thanks! |
That is interesting. I will look for a tool to make it automatically in CI |
Just a small question : some CI tests failed (also yesterday for my first version of the PR) is it normal or expected ? |
Hmm, it seems the expected behavior, because you are not whitelisted to run CI on ruche. |
Ok, thanks for the answer. |
Fix some typos in code and Doxygen comments.