Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos. #206

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix some typos. #206

merged 1 commit into from
Dec 3, 2024

Conversation

rb214678
Copy link
Collaborator

@rb214678 rb214678 commented Dec 2, 2024

Fix some typos in code and Doxygen comments.

@rb214678
Copy link
Collaborator Author

rb214678 commented Dec 2, 2024

There is also an other typo in unit_test/Test_Transform.cpp "neeed" that I did not fix because I don't know if it should be "need" or "needed". If you tell me I can rework my PR.

tpadioleau
tpadioleau previously approved these changes Dec 2, 2024
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, did you use any tool to get them ?

yasahi-hpc
yasahi-hpc previously approved these changes Dec 2, 2024
Copy link
Collaborator

@yasahi-hpc yasahi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thank

@yasahi-hpc
Copy link
Collaborator

There is also an other typo in unit_test/Test_Transform.cpp "neeed" that I did not fix because I don't know if it should be "need" or "needed". If you tell me I can rework my PR.

Regrading "neeed", they are supposed to be "needed". Could you please also fix them

@yasahi-hpc yasahi-hpc added the documentation Improvements or additions to documentation label Dec 3, 2024
@rb214678
Copy link
Collaborator Author

rb214678 commented Dec 3, 2024

Good catch, did you use any tool to get them ?

While reviewing a pull request, I noticed a first typo and then I decided to check if there were other typos. For this I used the spelling checker inside Vim.

@rb214678
Copy link
Collaborator Author

rb214678 commented Dec 3, 2024

There is also an other typo in unit_test/Test_Transform.cpp "neeed" that I did not fix because I don't know if it should be "need" or "needed". If you tell me I can rework my PR.

Regrading "neeed", they are supposed to be "needed". Could you please also fix them

I have done the update.

@yasahi-hpc
Copy link
Collaborator

There is also an other typo in unit_test/Test_Transform.cpp "neeed" that I did not fix because I don't know if it should be "need" or "needed". If you tell me I can rework my PR.

Regrading "neeed", they are supposed to be "needed". Could you please also fix them

I have done the update.

Thanks!

@yasahi-hpc
Copy link
Collaborator

Good catch, did you use any tool to get them ?

While reviewing a pull request, I noticed a first typo and then I decided to check if there were other typos. For this I used the spelling checker inside Vim.

That is interesting. I will look for a tool to make it automatically in CI

@yasahi-hpc yasahi-hpc merged commit 4b82641 into kokkos:main Dec 3, 2024
16 checks passed
@rb214678 rb214678 deleted the typo-fixes branch December 3, 2024 08:42
@rb214678
Copy link
Collaborator Author

rb214678 commented Dec 3, 2024

Just a small question : some CI tests failed (also yesterday for my first version of the PR) is it normal or expected ?

@yasahi-hpc
Copy link
Collaborator

Just a small question : some CI tests failed (also yesterday for my first version of the PR) is it normal or expected ?

Hmm, it seems the expected behavior, because you are not whitelisted to run CI on ruche.
https://github.com/kokkos/kokkos-fft/actions/runs/12135732423/job/33836388569#step:2:6

@rb214678
Copy link
Collaborator Author

rb214678 commented Dec 3, 2024

Just a small question : some CI tests failed (also yesterday for my first version of the PR) is it normal or expected ?

Hmm, it seems the expected behavior, because you are not whitelisted to run CI on ruche. https://github.com/kokkos/kokkos-fft/actions/runs/12135732423/job/33836388569#step:2:6

Ok, thanks for the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants