Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdalgos (7/10): team-level API, and rst update for release 4.2 #434

Merged
merged 9 commits into from
Jun 4, 2024
Merged

stdalgos (7/10): team-level API, and rst update for release 4.2 #434

merged 9 commits into from
Jun 4, 2024

Conversation

antoinemeyer5
Copy link
Collaborator

@antoinemeyer5 antoinemeyer5 commented Jul 5, 2023 •
edited by fnrizzi
Loading

Add team-level API to and convert to rst the following algorithms:

Kokkos_Unique.hpp
Kokkos_UniqueCopy.hpp
Kokkos_Rotate.hpp
Kokkos_RotateCopy.hpp
Kokkos_Remove.hpp
Kokkos_RemoveIf.hpp

NOTE: this follows the new structure for documenting the API, but does not use sphinx because the lack of properly aligning things make things quite unreadable.

Open individual html with Firefox (must be firefox or it won't display correctly)
Archive.zip

@antoinemeyer5 antoinemeyer5 mentioned this pull request Jul 5, 2023
Open
@antoinemeyer5 antoinemeyer5 self-assigned this Jul 6, 2023
antoinemeyer5
antoinemeyer5 commented Jul 17, 2023
View reviewed changes
Copy link
Collaborator Author

@antoinemeyer5 antoinemeyer5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add it @antoinemeyer5

docs/source/API/algorithms/std-algorithms/all/StdRemoveIf.rst Show resolved Hide resolved
This was referenced Aug 10, 2023
Merged
Merged
Merged
@fnrizzi fnrizzi changed the title std_algos: part 7/10: add team-level API and convert to rst (DO NOT MERGE UNTIL CODE PR MERGED) stdalgos: part 7/10: add team-level API and convert to rst (DO NOT MERGE UNTIL CODE PR MERGED) Dec 9, 2023
@fnrizzi fnrizzi changed the title stdalgos: part 7/10: add team-level API and convert to rst (DO NOT MERGE UNTIL CODE PR MERGED) stdalgos (7/N): team-level API, and rst update for release 4.2 Dec 10, 2023
@fnrizzi fnrizzi changed the title stdalgos (7/N): team-level API, and rst update for release 4.2 stdalgos (7/10): team-level API, and rst update for release 4.2 Dec 10, 2023
@fnrizzi fnrizzi marked this pull request as ready for review December 12, 2023 20:43
ajpowelsnl
ajpowelsnl approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@ajpowelsnl ajpowelsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoinemeyer5 , @fnrizzi , @crtrott -- a quick scan says it's good to go

@crtrott crtrott merged commit 7b9150e into kokkos:main Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpowelsnl ajpowelsnl ajpowelsnl approved these changes

@fnrizzi fnrizzi Awaiting requested review from fnrizzi

Assignees

@antoinemeyer5 antoinemeyer5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antoinemeyer5 @ajpowelsnl @crtrott @fnrizzi