Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdalgos (2/10): team-level API, and rst update for release 4.2 #366

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

fnrizzi
Copy link
Collaborator

@fnrizzi fnrizzi commented May 1, 2023

Add team-level API to and convert to rst the following algorithms:

Kokkos_Equal.hpp
Kokkos_Find.hpp
Kokkos_FindIf.hpp
Kokkos_FindIfNot.hpp
Kokkos_FindEnd.hpp
Kokkos_FindFirstOf.hpp

NOTE: this follows the new structure for documenting the API, but does not use sphinx because the lack of properly aligning things make things quite unreadable.

Open individual html with Firefox (must be firefox or it won't display correctly) Archive.zip

Example of rendered find_if:

image image image

@fnrizzi fnrizzi changed the title convert to rst and add team level API std_algos: part 2/10: add team-level API and convert to rst May 1, 2023
@fnrizzi fnrizzi marked this pull request as draft May 1, 2023 12:49
@fnrizzi fnrizzi changed the title std_algos: part 2/10: add team-level API and convert to rst std_algos: part 2/10: add team-level API and convert to rst (DO NOT MERGE UNTIL CODE PR MERGED) Jun 13, 2023
@fnrizzi fnrizzi changed the title std_algos: part 2/10: add team-level API and convert to rst (DO NOT MERGE UNTIL CODE PR MERGED) stdalgos (2/N): team-level API, and rst update for release 4.2 Sep 27, 2023
@fnrizzi fnrizzi marked this pull request as ready for review September 27, 2023 09:37
@fnrizzi fnrizzi changed the title stdalgos (2/N): team-level API, and rst update for release 4.2 stdalgos (2/10): team-level API, and rst update for release 4.2 Dec 10, 2023
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about how useful are the examples with explicit OpenMP.

bool isEqual = KE::equal(exespace, KE::begin(a), KE::end(a),
KE::begin(b), KE::end(b) p);

// assuming OpenMP is enabled, then you can also explicitly call
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Kokkos::DefaultHostExecutionSpace instead



Overload set accepting execution space
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to assume that execution space can be Host or Device?

@crtrott crtrott merged commit b3b46cc into kokkos:main Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants