This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
fix: fix selfUrl for ws-resverse
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注意到 [该 PR](#17) 指出 [该提交](f014bdd) 可能是错误的，那么 [该评论](#17 (comment)) 所提到的问题可能从未被修复。此 PR 意图修复此问题。 此 PR 对 `ws-resverse` 所唯一使用的 `selfUrl` 配置进行了如下修改： - 和 [这个错误的提交](f014bdd) 的做法相同，将 `port` 修改为使用 `this.ctx.router.port`。 - 将 `host` 强制设置为 `127.0.0.1`。理由在 [Koishi 的修改](satorijs/satori@241d57d) 和 [上个 PR](#17) 中均有阐述。同时注意这使得此处的 `selfUrl` 为本段代码专用，和其他作用域的 `selfUrl` 的意义不同。
shigma
approved these changes
May 8, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
注意到 该 PR 指出 该提交 可能是错误的，那么 该评论 所提到的问题可能从未被修复。此 PR 意图修复此问题。
此 PR 对
ws-resverse所唯一使用的selfUrl配置进行了如下修改：port修改为使用this.ctx.router.port。host强制设置为127.0.0.1。理由在 Koishi 的修改 和 上个 PR 中均有阐述。同时注意这使得此处的selfUrl为本段代码专用，和其他作用域的selfUrl的意义不同。