Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM allow same version #262

Merged
merged 1 commit into from
Jan 15, 2025
Merged

NPM allow same version #262

merged 1 commit into from
Jan 15, 2025

Conversation

mvandeberg
Copy link
Member

Brief description

When making proto releases, CI tags the version, but also fails. See the following:

https://app.travis-ci.com/github/koinos/koinos-proto/builds/272880003?serverType=git
https://app.travis-ci.com/github/koinos/koinos-proto/builds/272880321?serverType=git
https://app.travis-ci.com/github/koinos/koinos-proto/builds/272880323?serverType=git

And the version was still bumped (as desired):

koinos/koinos-proto-js@34a9175

This will allow npm version to succeed if the version is identical, making CI pass.

Checklist

  • I have built this pull request locally
  • I have ran the unit tests locally
  • I have manually tested this pull request
  • I have reviewed my pull request
  • I have added any relevant tests

Demonstration

@mvandeberg mvandeberg requested a review from sgerbino January 14, 2025 23:28
@sgerbino sgerbino merged commit 3263d54 into master Jan 15, 2025
1 check passed
@sgerbino sgerbino deleted the npm-same-version branch January 15, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants