Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new request/response to check transaction validity in mempool #223

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

sgerbino
Copy link
Member

@sgerbino sgerbino commented Mar 15, 2024

Resolves #222.

Brief description

Adds a new mempool RPC call that essentially combines the current checks into a single RPC which checks both resources and nonce validity.

Note that we make the optional block_id index number 1000 to allow for expansion of this call while keeping the optional arguments at the end.

Checklist

  • I have built this pull request locally
  • I have ran the unit tests locally
  • I have manually tested this pull request
  • I have reviewed my pull request
  • I have added any relevant tests

@mvandeberg mvandeberg merged commit 779409a into master Mar 15, 2024
2 checks passed
@mvandeberg mvandeberg deleted the 222-check-transaction-eligibility branch March 15, 2024 15:13
@mvandeberg mvandeberg restored the 222-check-transaction-eligibility branch March 19, 2024 21:11
@mvandeberg mvandeberg deleted the 222-check-transaction-eligibility branch March 19, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add generic RPC mempool request to check validity of transactions
2 participants