Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all possible forks when checking account resources #88

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

sgerbino
Copy link
Member

@sgerbino sgerbino commented Dec 22, 2022

Resolves #87.

Brief description

When checking if an account has available resources for a transaction, check all possible forks.

Checklist

  • I have built this pull request locally
  • I have ran the unit tests locally
  • I have manually tested this pull request
  • I have reviewed my pull request
  • I have added any relevant tests

Demonstration

Test project /Users/sgerbino/Projects/koinos-mempool/build/tests
    Start 1: koinos_mempool_tests-mempool_tests/mempool_basic_test
    Start 2: koinos_mempool_tests-mempool_tests/pending_transaction_pagination
    Start 3: koinos_mempool_tests-mempool_tests/pending_transaction_pruning
    Start 4: koinos_mempool_tests-mempool_tests/pending_transaction_dynamic_max_resources
    Start 5: koinos_mempool_tests-mempool_tests/fork_test
1/5 Test #1: koinos_mempool_tests-mempool_tests/mempool_basic_test ..........................   Passed    0.04 sec
2/5 Test #3: koinos_mempool_tests-mempool_tests/pending_transaction_pruning .................   Passed    0.04 sec
3/5 Test #4: koinos_mempool_tests-mempool_tests/pending_transaction_dynamic_max_resources ...   Passed    0.04 sec
4/5 Test #5: koinos_mempool_tests-mempool_tests/fork_test ...................................   Passed    0.05 sec
5/5 Test #2: koinos_mempool_tests-mempool_tests/pending_transaction_pagination ..............   Passed    0.63 sec

100% tests passed, 0 tests failed out of 5

Total Test time (real) =   0.64 sec

@mvandeberg mvandeberg merged commit 9e9fcfc into master Jan 3, 2023
@mvandeberg mvandeberg deleted the 87-check-pending branch January 3, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: check_pending_account_resources must match pending transaction acceptance
2 participants