Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Fork aware mempool #79

Closed
7 tasks done
sgerbino opened this issue Dec 6, 2022 · 0 comments · Fixed by #86
Closed
7 tasks done

[FEATURE]: Fork aware mempool #79

sgerbino opened this issue Dec 6, 2022 · 0 comments · Fixed by #86
Labels
enhancement New feature or request story

Comments

@sgerbino
Copy link
Member

sgerbino commented Dec 6, 2022

Is there an existing issue for this?

  • I have searched the existing issues

New feature

As a Koinos user, I would like a fork aware mempool such that transactions do not get forgotten on forks.

Note: Upon startup, the statedb root should be genesis (0x00). If transactions come in prior to a LIB, apply the transactions directly to the genesis node. When LIB comes in, attempt to attach it to previous, if there is no previous attempt to attach the node to genesis. If there is no genesis, report an error because something went wrong.

Anything else?

Right now it is possible for a transaction to end up on a fork, the cluster makes no attempt to re-apply this transaction on the main fork. This will cause bad UX for both users.

@sgerbino sgerbino added enhancement New feature or request story labels Dec 6, 2022
sgerbino added a commit that referenced this issue Dec 12, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
sgerbino added a commit that referenced this issue Dec 13, 2022
sgerbino added a commit that referenced this issue Dec 13, 2022
sgerbino added a commit that referenced this issue Dec 13, 2022
… loss of any known transaction, updated test to reflect this
sgerbino added a commit that referenced this issue Dec 13, 2022
sgerbino added a commit that referenced this issue Dec 14, 2022
sgerbino added a commit that referenced this issue Dec 14, 2022
sgerbino added a commit that referenced this issue Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant