Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds KCS-4 #12

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Adds KCS-4 #12

merged 6 commits into from
Jun 20, 2024

Conversation

sgerbino
Copy link
Member

Resolves #10.

@sgerbino
Copy link
Member Author

All protocol buffer method arguments should be _arguments and all results should be _result. Also, we should add each of these standards to https://github.com/koinos/koinos-proto. I propose we put them in contracts/standard/kcs-*.proto. I did not completely review all of these refactors, simply normalize them so they can be reviewed individually.

Copy link
Member

@mvandeberg mvandeberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The argument proto types mix use of the _args and _arguments suffixes.

@sgerbino sgerbino requested a review from mvandeberg June 13, 2024 01:14
@mvandeberg mvandeberg merged commit 1e47100 into master Jun 20, 2024
@mvandeberg mvandeberg deleted the kcs-4 branch June 20, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KCS-4
3 participants