Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added failing test cases for dateFromString #229

Closed
wants to merge 1 commit into from

Conversation

ErisDS
Copy link

@ErisDS ErisDS commented Feb 24, 2022

refs #228

  • These demonstrate the issue with dateFromString not working if there is a Z in dateString

I have done a bit of debugging and discovered that it's failing on the regex.exec clause here:

!new RegExp("^" + expectedPattern + "$").exec(args.dateString)

But I'm not entirely sure what that clause is meant to do so I'm a little unsure what a fix would look like.

refs: kofrasa#228

- These demonstrate the issue with dateFromString not working if there is a Z at the end of dateString
@kofrasa
Copy link
Owner

kofrasa commented Feb 24, 2022

Resolved in 6.0.5. Thanks for this test case.

@kofrasa kofrasa closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants