Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library does not work on IE11 because of Symbol being undefined #124

Closed
squallstar opened this issue Mar 4, 2020 · 6 comments
Closed

Library does not work on IE11 because of Symbol being undefined #124

squallstar opened this issue Mar 4, 2020 · 6 comments

Comments

@squallstar
Copy link

squallstar commented Mar 4, 2020

Hello, is there any chance we can get a version of the dist js which works on IE11?

It currently doesn't work because Symbol is undefined so a polyfill will be necessary during the transpiling.

I have tested the latest JS files in the dist folder against IE11.

Many thanks.

@squallstar squallstar changed the title Does not work on IE11 because of Symbol being undefined Library does not work on IE11 because of Symbol being undefined Mar 4, 2020
@kofrasa
Copy link
Owner

kofrasa commented Mar 8, 2020

Hi @squallstar, thanks for opening this issue.

I am not sure adding a polyfill is the right thing to do here. The Symbol object is not required to run Mingo and is only added as a convenience to enable for..of style iteration.

Perhaps the correct thing to add a guard to test for the Symbol support and only add the iterator if it is available in the environment. This frees up users to bring their own polyfill if they want to use the for..of style syntax.

@squallstar
Copy link
Author

@kofrasa thanks! Really appreciate the patch you made. Are all dist files up to date so that I can make use of your patch?

@kofrasa
Copy link
Owner

kofrasa commented Mar 10, 2020

Yes, the changes are available in dist for release 2.5.0. All files are up to date and should run fine even in environments without Symbol support.

Happy Coding.

@squallstar
Copy link
Author

@kofrasa unfortunately this is still an issue on IE11 because "Object.assign" is not supported (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign).

@kofrasa
Copy link
Owner

kofrasa commented Apr 9, 2020

I will make the fix as part of 3.0.0 which attempts to baseline IE support to version 9.

@squallstar
Copy link
Author

@kofrasa thanks, meanwhile I have added the above polyfill to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants