Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling battery indicator from status bar #60

Closed
weslly opened this issue Jun 23, 2019 · 4 comments
Closed

Allow disabling battery indicator from status bar #60

weslly opened this issue Jun 23, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@weslly
Copy link

weslly commented Jun 23, 2019

I have a mac mini and the battery widget always show 0% because I don't have a battery. Would it be possible to disable it from the status bar with a config option?
koekeishiya added a commit that referenced this issue Jun 23, 2019
@koekeishiya
#60 hide battery indicator from bar if no battery was found
e67b6a3
@koekeishiya koekeishiya added the addressed on master; not released Fixed upstream, but not yet released label Jun 23, 2019
@koekeishiya
Copy link
Owner

koekeishiya commented Jun 23, 2019 •
edited
Loading

On master we check for the existence of a battery, and hide the indicator if none could be found.

@koekeishiya koekeishiya added the enhancement New feature or request label Jun 23, 2019
@koekeishiya koekeishiya removed the addressed on master; not released Fixed upstream, but not yet released label Jun 25, 2019
@weslly
Copy link
Author

weslly commented Jun 26, 2019

@koekeishiya for some reason this only works when I compile and link the binary myself. But when I install from brew install yabai (v 1.0.2, and even --HEAD), it still shows the battery indicator.

@weslly
Copy link
Author

weslly commented Jun 26, 2019

@koekeishiya found the reason, actually it only works when compiled with make, not make install. Could be something with the make flags.

@koekeishiya
Copy link
Owner

Sounds weird to me. The only difference in build settings are -g -O0 and -O2

koekeishiya added a commit that referenced this issue Jun 26, 2019
@koekeishiya
#60 fixed an issue with default initialization of variables when no p…
429fdd7 
…ower sources are available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weslly @koekeishiya