Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in space_manager_handle_display_add #375

Closed
choco opened this issue Jan 20, 2020 · 1 comment
Closed

Crash in space_manager_handle_display_add #375

choco opened this issue Jan 20, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@choco
Copy link

choco commented Jan 20, 2020

Yesterday I updated yabai to last commit and I got this crash a couple of times today at work:

Thread 2 Crashed:
0   libobjc.A.dylib               	0x00007fff6ddb201d objc_msgSend + 29
1   com.apple.CoreFoundation      	0x00007fff37beff2e CFEqual + 622
2   yabai                         	0x00000001055ec96d space_manager_handle_display_add + 333
3   yabai                         	0x00000001055fae52 EVENT_HANDLER_DISPLAY_ADDED + 50
4   yabai                         	0x00000001055d69ce event_loop_run + 94
5   libsystem_pthread.dylib       	0x00007fff6f330e65 _pthread_start + 148
6   libsystem_pthread.dylib       	0x00007fff6f32c83b thread_start + 15

I didn't actually connect an external display, so the event probably comes from the discrete graphics card kicking in. I'll try to have better reproduction steps and a better backtrace.
koekeishiya added a commit that referenced this issue Jan 20, 2020
@koekeishiya
#375 fix use after free
2c3f854
@koekeishiya koekeishiya added addressed on master; not released Fixed upstream, but not yet released bug Something isn't working labels Jan 20, 2020
@koekeishiya
Copy link
Owner

Well that was stupid. Fixed on master.

@koekeishiya koekeishiya removed the addressed on master; not released Fixed upstream, but not yet released label Jan 20, 2020
brorbw pushed a commit to brorbw/yabai that referenced this issue Jan 28, 2020
@koekeishiya @brorbw
koekeishiya#375 fix use after free
eccf88b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@choco @koekeishiya