code cleanup about src/dsp_dab/charsets.[cpp|h] #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This slightly cleans the files to match more the original. There was e.g. some tabs added where then differ from version before and more hard to compare about code changes.
The background is cleanup and the same type of functionality is also located in "src/dsp_hd/unicode.*" (which was even created from this code in the past). The aim is to combine the general help functions of the different radio types and to correspond to a code style. Code cleanups will be added after this commit.
AlwinEsch
commented
Apr 4, 2024
src/utils/charsets.cpp
Outdated
| * Copyright (C): 2015 Jan van Katwijk ([email protected]) | ||
| * Name: Lazy Chair Programming | ||
| * Note: This charset handling was kindly added by Przemyslaw Wegrzyn all rights acknowledged | ||
| */ |
There was a problem hiding this comment.
Hi @ksooo, can you look here? Not sure how the best style to cleanup and match our style and still refer code good as possible to original. Maybe a better idea?
AlwinEsch
force-pushed
the
cleanup
branch
4 times, most recently
from
2ad501a to
55ca8db
Compare
This cleans up the two files src/utils/charsets.cpp and src/utils/charsets.h to correspond to our clang format, and the code is added to a namespace to be cleaner on the outside, public is the namespace "charsets" in the cpp then a pseudo namespace for private functions so that it is not known to the outside world.
This changes some small pieces of code to have slightly better performance in some cases.
ksooo
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the changes that relates to the Kodi site and is more in line with its style.
The two files “src/dsp_dab/charsets.cpp” and “src/dsp_dab/charsets.h” are revised and taken from the “src/dsp_dab” folder (welle.io). The background is to standardize the auxiliary functions of different process types, as an example the code was taken from welle.io from the code from https://github.com/theori-io/nrsc5, which is currently also in the add-on under "src/ dsp_hd/unicode.c" and "src/dsp_hd/unicode.h".
Since "src/dsp_hd/unicode.c" is currently based on "C", this has not yet been attacked. This will only come into play once the change has been made and runtime tests have been carried out.