improvement and fixes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlwinEsch
force-pushed
the
Omega-change2
branch
from
5958aa2 to
0190b7f
Compare
|
Note about commit "move libfec parts to own folder", after this comes much times crash on playbacks. |
ksooo
reviewed
Mar 31, 2024
pvr.rtlradio/resources/language/resource.language.en_gb/strings.po
Outdated
Show resolved
Hide resolved
AlwinEsch
force-pushed
the
Omega-change2
branch
from
0190b7f to
fdf624b
Compare
NOTE: Original defines renamed from Hz, kHz & MHz to have "Value" on end, this to fix conflicts within Windows Visual Studio defined ones.
AlwinEsch
force-pushed
the
Omega-change2
branch
from
fdf624b to
21b3509
Compare
Further cleaned up the code itself with: - Remove "goto" usage - Don't set code values by defines - Removed not needed encode source - No more malloc/free in process, done on init/deinit now
|
Thanks @ksooo for review, commented places are fixed. About the settings I increased the text and now shown as this, what you think, OK as this or another idea about?: |
|
Yes, this is better. Thanks. |
All other files in src/compat was not used.
Within Kodi's build system they can not be used in all cases.
As now only macros about value sizes inside becomes it renamed and moved to the utils folder.
Before was the "dsp" on end of name, this now changed to have folders in better alphabetical flow and no mix with other folders.
As there some of them, looks it cleaner to have in own folder about.
Also to have more clean and files better sorted.
ksooo
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make add-on better usable and implement missing settings features.