Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection manager support to wait for a valid M3U file before starting the add-on instance #823

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

phunkyfish
Copy link
Member

@phunkyfish phunkyfish commented Jan 1, 2024

v21.7.0

  • Add connection manager support to wait for a valid M3U file before starting the add-on instance
  • The minimum refresh interval for the M3U should be 1 minutes and not zero, as that would be infinite refresh

@phunkyfish phunkyfish force-pushed the startup-conn-mgr branch 2 times, most recently from 44fdc68 to 10760c8 Compare January 2, 2024 11:12
@phunkyfish
Copy link
Member Author

New testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.iptvsimple/detail/PR-823/3/artifacts

Question, what behaviour do you get/expect if there is no M3U URL set?

@phunkyfish
Copy link
Member Author

phunkyfish commented Jan 3, 2024

Question, what behaviour do you get/expect if there is no M3U URL set?

Any response here? Actually NVM. I'll just have it wait for URL to be set before validating it.

New testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.iptvsimple/detail/PR-823/5/artifacts

@matthuisman
Copy link
Contributor

matthuisman commented Jan 4, 2024

hmm. something seems off now. after booting - i get empty channels and epg.
I see it being loaded in the log though.
If i go Clear PVR data then it all appears

It doesnt show as pvr manager starting up either like it used too.

I went back to https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.iptvsimple/detail/PR-823/1/artifacts and that works

https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.iptvsimple/detail/PR-823/2 has no windows x64
but /3 is were it "breaks"

@phunkyfish
Copy link
Member Author

Hmmm, I won’t have history so hard to figure out the change that breaks it.

Can you explain your set up to me?

@phunkyfish
Copy link
Member Author

phunkyfish commented Jan 4, 2024

I bet it's because we removed the notification. My guess is it also updates Kodi PVR of the state change.

Yup, that was it. New builds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.iptvsimple/detail/PR-823/8/artifacts

@matthuisman
Copy link
Contributor

thank you. have tested and works good now :)

@phunkyfish phunkyfish merged commit cc885d2 into kodi-pvr:Omega Jan 4, 2024
7 checks passed
@phunkyfish phunkyfish deleted the startup-conn-mgr branch January 4, 2024 21:56
@matthuisman
Copy link
Contributor

matthuisman commented Jan 4, 2024

@phunkyfish I forgot to test local paths!

Just tried them now and they dont seem to work.

Localpath: special://userdata/addon_data/plugin.program.iptv.merge/playlist.m3u8

Just constantly get logged:
AddOnLog: pvr.iptvsimple: pvr.iptvsimple - Check Unable to open url: special://userdata/addon_data/plugin.program.iptv.merge/playlist.m3u8

I still think be nice if it retried for local paths as well, but maybe the check method needs to handle local paths?

@phunkyfish
Copy link
Member Author

I implemented it using local paths, but just the regular filesystem and not special paths. They should just work too though.

Will take a look later.

@phunkyfish
Copy link
Member Author

Please test the fix here: #826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants