-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection manager support to wait for a valid M3U file before starting the add-on instance #823
Conversation
…zero, as that would be infinite refresh
44fdc68
to
10760c8
Compare
New testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.iptvsimple/detail/PR-823/3/artifacts Question, what behaviour do you get/expect if there is no M3U URL set? |
10760c8
to
cab327d
Compare
Any response here? Actually NVM. I'll just have it wait for URL to be set before validating it. New testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.iptvsimple/detail/PR-823/5/artifacts |
cab327d
to
be09a52
Compare
hmm. something seems off now. after booting - i get empty channels and epg. It doesnt show as pvr manager starting up either like it used too. I went back to https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.iptvsimple/detail/PR-823/1/artifacts and that works https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.iptvsimple/detail/PR-823/2 has no windows x64 |
Hmmm, I won’t have history so hard to figure out the change that breaks it. Can you explain your set up to me? |
be09a52
to
ee1e3d2
Compare
I bet it's because we removed the notification. My guess is it also updates Kodi PVR of the state change. Yup, that was it. New builds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.iptvsimple/detail/PR-823/8/artifacts |
…arting the add-on instance
ee1e3d2
to
35071a5
Compare
thank you. have tested and works good now :) |
@phunkyfish I forgot to test local paths! Just tried them now and they dont seem to work. Localpath: special://userdata/addon_data/plugin.program.iptv.merge/playlist.m3u8 Just constantly get logged: I still think be nice if it retried for local paths as well, but maybe the check method needs to handle local paths? |
I implemented it using local paths, but just the regular filesystem and not special paths. They should just work too though. Will take a look later. |
Please test the fix here: #826 |
v21.7.0