Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are some mistakes with the README.markdown and Selection Sampling code improvement #998

Open
efemazlumoglu opened this issue Apr 4, 2022 · 0 comments
Open

There are some mistakes with the README.markdown and Selection Sampling code improvement #998

efemazlumoglu opened this issue Apr 4, 2022 · 0 comments

Comments

@efemazlumoglu
Copy link

Brief Intro

#997
I have created this PR for that issue, there are some mistakes in the README files and also a little improvement for the Selection Sampling example function.

More Details

swap(&a[i], &a[r]) can be written like a.swapAt(i, r)
That would be remove the error called "Overlapping accesses to 'a', but modification requires exclusive access; consider calling MutableCollection.swapAt(::)"
Mrgig7 added a commit to Mrgig7/swift-algorithm-club-study that referenced this issue Oct 7, 2024
@Mrgig7
issue resolved kodecocodes#997 and kodecocodes#998
5e8c029 
Correction of the README.markdown and Selection Sampling code improvement kodecocodes#998
@Mrgig7 Mrgig7 mentioned this issue Oct 7, 2024
Merged
2 tasks
kelvinlauKL added a commit that referenced this issue Dec 6, 2024
@kelvinlauKL
Merge pull request #1024 from Mrgig7/master
f2b7367 
issue resolved  #997 and #998
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@efemazlumoglu