🔧 wip: nuxt3 #6917

roiLeo · 2023-08-23T13:55:24Z

ref Towards Vue 3 / Nuxt 3 migration roadmap #2690

@kodadot/code-review-guild I'm stuck on some build errors if anyone want to try out feel free to checkout this branch

Goal is to display simple hello world on Landing

netlify · 2023-08-23T13:55:33Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`392bf0b`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64ee0e3b37b65e00083d8132
😎 Deploy Preview	https://deploy-preview-6917--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

reviewpad · 2023-08-23T13:56:01Z

Reviewpad Report

⚠️ Warnings

Please link an issue to the pull request

codeclimate

The PR diff size of 17895 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 27387 lines exceeds the maximum allowed for the inline comments feature.

socket-security · 2023-08-23T14:02:41Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
rollup	2.0.0	None	`+0`	2.65 MB	lukastaegert
vite	3.2.7...4.2.0	environment	`+4/-4`	3.78 MB	vitebot
histoire	0.16.4...0.16.2	None	`+5/-7`	5.86 MB	akryum
vitest	0.34.1...0.34.2	None	`+10/-12`	11.1 MB	oreanno

🚮 Removed packages: @nuxt/[email protected], [email protected], [email protected]

socket-security · 2023-08-23T14:02:44Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

yangwao · 2023-08-23T14:09:57Z

Hey, is insider trading allowed, what do you think
https://app.zeitgeist.pm/markets/238

yangwao · 2023-08-24T10:25:53Z

maybe @stephenjason89 😄

codeclimate

The PR diff size of 28833 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 24513 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 24541 lines exceeds the maximum allowed for the inline comments feature.

roiLeo · 2023-08-24T14:40:55Z

Now it builds 🎊

stephenjason89 · 2023-08-24T15:43:11Z

Good job @roiLeo, It's 12midnight here. If you need help just let me know. My tg handle is SOW89

codeclimate

The PR diff size of 24077 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 20746 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 20768 lines exceeds the maximum allowed for the inline comments feature.

yangwao · 2023-08-29T09:00:01Z

What's the strategy for merging this?

You want to do page by page or do some nuxt layout?

roiLeo · 2023-08-29T09:10:00Z

What's the strategy for merging this?

Wait for some issue to be resolved, I can handle conflicts & push from others (fork my repo)

Packages migration audit #6911 : devs can handle package migration, one by one (some of them have been made) link Refactor: Nuxt3 plugins #5314
Programmatic Modal #6277 : major need

You want to do page by page or do some nuxt layout?

fix all gql calls (some of theme have been fixed) page by page & components by components

From #2690 (comment)

I've done:

upgrade to nuxt3, remove nuxt-bridge & edge
upgrade i18
upgrade @nuxtjs/apollo
update layouts & page with vue3 composition (<NuxtLayout><NuxtPage /></NuxtLayout>)
rename /static folder to /public

We need to fix some packages config now.

@stephenjason89 have you made some progress on I18n plugin?

preschian · 2023-08-29T09:17:45Z

@roiLeo, it seems like we can use a proxy to gradually release it to the user page by page. Maybe we can start with /blog by implementing @nuxt/content? It would be great if we could support SSR also for /blog. So, we can drop prerender.io for /blog

fix all gql calls (some of theme have been fixed) page by page & components by components

I think this is the major one

#6277 : major need

this one can't be solved with just a fork?

preschian · 2023-08-29T09:21:24Z

@roiLeo, but if you prefer not to use a proxy, we can stick with this way

rename /static folder to /public

Are there any changes that need to merge in main to reduce the diff? I guess that renaming /static to /public can be made in the main branch

roiLeo · 2023-08-29T09:33:33Z

@roiLeo, it seems like we can use a proxy to gradually release it to the user page by page. Maybe we can start with /blog by implementing @nuxt/content? It would be great if we could support SSR also for /blog. So, we can drop prerender.io for /blog

nuxt/content doesn't work on ssr: false, SSR support will be a major update, I don't think it's a good idea to realease first version of nuxt3 with it.

#6277 : major need

this one can't be solved with just a fork?

wdym? I want to use it like it's on Doc (const { oruga } = useProgrammatic()) I think we can extend it (const { neo } = useProgrammatic())

@roiLeo, but if you prefer not to use a proxy

I'd rather not

rename /static folder to /public

Are there any changes that need to merge in main to reduce the diff? I guess that renaming /static to /public can be made in the main branch

Idk if public folder is working with nuxt-bridge

preschian · 2023-08-29T09:56:57Z

wdym? I want to use it like it's on Doc (const { oruga } = useProgrammatic()) I think we can extend it (const { neo } = useProgrammatic())

You need to fork this script first https://github.com/oruga-ui/oruga/blob/4915c4dbcb1a6c2cd39bc7660d41916b330bc0cd/packages/oruga-next/src/components/modal/index.ts#L8. actually similar with what I do in this PR https://github.com/kodadot/nft-gallery/pull/6714/files#diff-a59a359d665e8dbbfbd08707a6b82aab528e21e3debcfc707f81d7f505015073R9

what I do in that PR:

I fork their implementation and put it here libs/ui/src/components/NeoModalExtend/plugin.js
inject it in our plugin here plugins/oruga-modal.ts

and then can create or inject the composables through a plugin. this is how they install it to the plugin:

I can help with this one once I'm done with a simple mint

yangwao · 2023-08-29T10:01:59Z

Wait for some issue to be resolved

So I can create a new chief issue for migration and replace this one?

Towards Vue 3 / Nuxt 3 migration roadmap #2690 (comment)

To not break our current flow and keep a flawless release cycle, I would propose making alpha branch with a deployment.

Later we can still back merge new things and once it is even 1:1 alpha with main we can update.

lmk and I can proceed.

Hanging out in one PR for this major upgrade is not so good I think.

roiLeo · 2023-08-29T10:14:32Z

I can help with this one once I'm done with a simple mint

Yes please! could you push your code to my repo?

codeclimate

The PR diff size of 20806 lines exceeds the maximum allowed for the inline comments feature.

roiLeo · 2023-08-29T10:24:32Z

So I can create a new chief issue for migration and replace this one?

finish Reduce using nuxt-property-decorator and use composition API #4750 first

To not break our current flow and keep a flawless release cycle, I would propose making alpha branch with a deployment.

IMO, it's better that someone (Kodadev insider) handle the migration, it would be less exhausting than having to go through multiple reviews and better to resolve conflicts.

Later we can still back merge new things and once it is even 1:1 alpha with main we can update.

Yes! Once we fix oruga (programmatic) & apollo config, we could be able to release an alpha branch.

Hanging out in one PR for this major upgrade is not so good I think.

why that?

note: not happening before 01/09 sorry

daiagi · 2023-08-29T11:40:13Z

@roiLeo
I'm lost in the discussion
is there anything concrete I can help you with right now?

roiLeo · 2023-08-29T11:46:27Z

@roiLeo I'm lost in the discussion is there anything concrete I can help you with right now?

Would you like to check/fix a component, a page or a plugin? Just let me know wich part you want to work on.
For now preschian want to work on programmatic modal (oruga modal) & stephen is on i18n config.

daiagi · 2023-08-29T12:44:26Z

component/page please

roiLeo · 2023-08-29T12:48:28Z

component/page please

Try first with something easy/doable like spotlight, series-insight, assets page then push on my repo and I'll merge it as quickly as I can (if it's working)

edit:

📔 To anyone going to work with page/component that use $apollo here's how to replace it:

BASIC:

const { result: res } = useQuery(query, variables)

CALLBACK

const res = ref()
const { onResult } = useQuery(query, variables)
onResult((result) => (res.value = result.data))

ASYNC f°:

const res = ref()
const fetchData = async () => {
  const { data } = await useAsyncQuery(query, { ...variables })
  res.value = data
}

codeclimate

The PR diff size of 20842 lines exceeds the maximum allowed for the inline comments feature.

codeclimate · 2023-08-29T15:27:25Z

Code Climate has analyzed commit 392bf0b and detected 0 issues on this pull request.

View more on Code Climate.

sonarcloud · 2023-08-29T15:28:24Z

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities
0 Security Hotspots
35 Code Smells

No Coverage information
0.6% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

yangwao · 2023-08-29T18:08:57Z

IMO, it's better that someone (Kodadev insider) handle the migration, it would be less exhausting than having to go through multiple reviews and better to resolve conflicts.

I've made nuxt branch, deployment is working on https://nuxt.kodadot.xyz

@roiLeo please merge it there what you have and we can split load. Thank you for understanding.

why that?

This

and because the process is not around the KodaDot branch in this repository and we can split load among others, not make you block migration by single dev on resolving conflicts. Hopefully, you understand.

Rather encourage split tasks in

Nuxt3 - merging strategy #7034

For others likewise, making it against nuxt branch.

roiLeo · 2023-08-30T06:43:15Z

continue in 🔧 nuxt3 migration #7039

roiLeo added 5 commits August 7, 2023 19:12

🔧 libs ui vue3

831e6ec

🔧 plugin vue

05e62a7

➖ nitro config

895517f

🔧 wip: nuxt3

46fd835

🔧 allow undefined function

27b8b94

roiLeo requested a review from a team as a code owner August 23, 2023 13:55

roiLeo requested review from vikiival and Jarsen136 and removed request for a team August 23, 2023 13:55

roiLeo marked this pull request as draft August 23, 2023 13:55

reviewpad bot added the large Pull request is large label Aug 23, 2023

codeclimate bot reviewed Aug 23, 2023

View reviewed changes

🔧 conflicts

0684f72

codeclimate bot reviewed Aug 23, 2023

View reviewed changes

🔧 wip: sub-api

9e4974e

codeclimate bot reviewed Aug 24, 2023

View reviewed changes

🔧 wip: made some progress

9752b4d

codeclimate bot reviewed Aug 24, 2023

View reviewed changes

🔧 wip: nuxt3 nitro build

509c2df

codeclimate bot reviewed Aug 24, 2023

View reviewed changes

🔧 Nuxt3 fa-icons

08b7d56

codeclimate bot reviewed Aug 25, 2023

View reviewed changes

codeclimate bot reviewed Aug 28, 2023

View reviewed changes

🔧 collection id & safe href

7dc92c2

codeclimate bot reviewed Aug 28, 2023

View reviewed changes

🔧 item id & profile id

b4baea7

🔧 conflicts

5f2109b

codeclimate bot reviewed Aug 29, 2023

View reviewed changes

🔧 conflicts

2c39f36

roiLeo added 2 commits August 29, 2023 17:25

🔧 tests & create page

b7c873a

🔧 conflicts

392bf0b

codeclimate bot reviewed Aug 29, 2023

View reviewed changes

yangwao mentioned this pull request Aug 29, 2023

Nuxt3 - merging strategy #7034

Closed

18 tasks

roiLeo mentioned this pull request Aug 30, 2023

🔧 nuxt3 migration #7039

Merged

roiLeo closed this Aug 30, 2023

🔧 wip: nuxt3 #6917

🔧 wip: nuxt3 #6917

Conversation

roiLeo commented Aug 23, 2023 • edited Loading

netlify bot commented Aug 23, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

reviewpad bot commented Aug 23, 2023

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

socket-security bot commented Aug 23, 2023 • edited Loading

socket-security bot commented Aug 23, 2023 • edited Loading

yangwao commented Aug 23, 2023

yangwao commented Aug 24, 2023

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

roiLeo commented Aug 24, 2023

stephenjason89 commented Aug 24, 2023

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

yangwao commented Aug 29, 2023

roiLeo commented Aug 29, 2023

preschian commented Aug 29, 2023

preschian commented Aug 29, 2023

roiLeo commented Aug 29, 2023 • edited Loading

preschian commented Aug 29, 2023 • edited Loading

yangwao commented Aug 29, 2023

roiLeo commented Aug 29, 2023

codeclimate bot left a comment

Choose a reason for hiding this comment

roiLeo commented Aug 29, 2023 • edited Loading

daiagi commented Aug 29, 2023

roiLeo commented Aug 29, 2023

daiagi commented Aug 29, 2023

roiLeo commented Aug 29, 2023 • edited Loading

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot commented Aug 29, 2023

sonarcloud bot commented Aug 29, 2023

yangwao commented Aug 29, 2023

roiLeo commented Aug 30, 2023

roiLeo commented Aug 23, 2023 •

edited

Loading

netlify bot commented Aug 23, 2023 •

edited

Loading

socket-security bot commented Aug 23, 2023 •

edited

Loading

socket-security bot commented Aug 23, 2023 •

edited

Loading

roiLeo commented Aug 29, 2023 •

edited

Loading

preschian commented Aug 29, 2023 •

edited

Loading

roiLeo commented Aug 29, 2023 •

edited

Loading

roiLeo commented Aug 29, 2023 •

edited

Loading