fix: rmrk2 fallback images #6903
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
AI-Generated Summary: This pull request consists of three patches that concentrate on fixing issues related to the image handling and metadata processing in the gallery, carousel, and collections popover components. The first patch focuses on the 'useGalleryItem.ts' component and the 'useNft.ts' file. Changes ensure images and animations from the NFT resources are correctly picked up and sanitized. Additionally, new metadata attributes were added for the NFT object in 'useNft.ts'. The second patch modifies 'carousel.ts' and ensures the correct image source is used by adjusting the order of preference for which image to display in case of missing images. The final patch revolves around the 'GalleryCard.vue' component. It adjusts the way metadata is processed and changes how images and titles are obtained and sanitized. It also introduced more flexibility by changing a number of properties to have default values and be optional. |
|
Reviewpad Report
|
|
Code Climate has analyzed commit d5ed0b2 and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
preschian
requested review from
vikiival and
daiagi
and removed request for
a team
| const imageSrc = | ||
| resource.meta?.animationUrl || | ||
| resource.src || | ||
| resource.meta?.image || | ||
| resource.thumb | ||
|
|
There was a problem hiding this comment.
not part of this PR for sure
but why do we have so many possible sources?
There was a problem hiding this comment.
There was a problem hiding this comment.
Because Bruno said so
counting days we will deprecate it
|
pay 50 usd |
|
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at aae7f9b
This pull request improves the functionality and performance of the GalleryCard component and the useGalleryItem composable, by refactoring the code, fixing bugs, and adding a new meta property to the NftResources type. It also removes unused code and enhances the lazy loading of image data.
🤖 Generated by Copilot at aae7f9b