Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove prevent default event from function #6891

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Conversation

thnaylor
Copy link
Contributor

@thnaylor thnaylor commented Aug 22, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Comments

Suggestion was committed in #6844 but also required an update to the switchChain function.

Copilot Summary

🤖 Generated by Copilot at 29909f8

Refactored the switchChain function in SearchLanding.vue to use a v-model binding instead of a click event. This simplifies the code and avoids unnecessary calls to event.preventDefault().

🤖 Generated by Copilot at 29909f8

switchChain function
No longer needs event
v-model binds it

@kodabot
Copy link
Collaborator

kodabot commented Aug 22, 2023

WARNING @thnaylor PR for issue #6890 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6890

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6f9d184
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e5abde7b8afd0008327807
😎 Deploy Preview https://deploy-preview-6891--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 22, 2023

AI-Generated Summary: This pull request introduces a minor change in the "SearchLanding.vue" component of the landing page. The function 'switchChain' no longer prevents the default event. The 'preventDefault' method call has been removed from the function definition, which makes the event behavior consistent with the default browser behavior.

@reviewpad reviewpad bot added the small Pull request is small label Aug 22, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 22, 2023

Code Climate has analyzed commit c413ae2 and detected 0 issues on this pull request.

View more on Code Climate.

@thnaylor thnaylor marked this pull request as ready for review August 22, 2023 19:42
@thnaylor thnaylor requested a review from a team as a code owner August 22, 2023 19:42
@thnaylor thnaylor requested review from preschian and vikiival and removed request for a team August 22, 2023 19:42
@roiLeo roiLeo merged commit d09c3b6 into kodadot:main Aug 23, 2023
4 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yangwao
Copy link
Member

yangwao commented Aug 23, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Aug 23, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.41 USD/DOT ~ 6.803 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0x1bc41286e9dbf4d32686da357457ddd85d47ac1b8d53f99f4bed901592511103

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network list on landing page not working
5 participants