Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong price at landing lists #6881

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 22, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at 5e192b1

The pull request adds support for different chain formats to the carousel and money components. It uses the Prefix type and the chainPropListOf function from @kodadot1/static to get the chain properties and pass them as props to the Money component.

🤖 Generated by Copilot at 5e192b1

Sing, O Muse, of the skillful coder who devised
A clever prop for the Money component, and thus
Displayed the price of NFTs in various chains
With proper decimals and symbols, as befits their fame.

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 22, 2023 16:20
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team August 22, 2023 16:20
@kodabot
Copy link
Collaborator

kodabot commented Aug 22, 2023

SUCCESS @Jarsen136 PR for issue #6880 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5e192b1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e4e06d9512a6000827d691
😎 Deploy Preview https://deploy-preview-6881--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 22, 2023

AI-Generated Summary: This pull request includes changes across three components (types.ts, CarouselInfo.vue, Money.vue) to fix an issue with the display of wrong prices at landing lists. The type of the chain attribute in the BaseMintedCollection interface has been updated from string to Prefix. In the CarouselInfo.vue module, a prefix item has been added to the Money component. Major changes have been performed in the Money.vue component, where extra computation of tokenDecimals is performed based on the prefix and utilized in the finalValue computation block to ensure correct price detail.

@codeclimate
Copy link

codeclimate bot commented Aug 22, 2023

Code Climate has analyzed commit 5e192b1 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 22, 2023
@yangwao yangwao merged commit 2295849 into kodadot:main Aug 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong price at landing lists - 579 != 5.79
6 participants